Some common things to bear in mind when reviewing pull requests
Items tagged code
Camus, code, grammatical nerd sniping, and why caring about standards is like being condemned to an eternity of pushing a boulder up a hill.
It’s good to take the opportunity to clean up your code as you go along, especially on big projects that will be maintained for a while. After all, the chances that you'll go back and fix those little things later is pretty slim.
Recently I had to investigate a strange bug that only happened on our pre-production environment. Code that was fine all through our other development and test environments was causing a white screen of death on the home page. Not good. We’re a big team, and we have quite a strict code review process, so in theory no code should get into the main branch unless it’s had at least two pairs of eyes on it, and nothing should get through to pre-production unless it's been tested in two other shared environments, plus the developer's local machine.
While most of the attention during Seb Lee-Delisle's session at smashing conference was focused on the lasers, something else he showed reminded me that I've been meaning to explore canvas animation for ages. In just a few lines of code, he created a spinning, colour-shifting shape on the screen.